WebGLBackend: Fix manual clear with MSAA render targets. #31705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
commented
Aug 21, 2025
| } | ||
|
|
||
| this._currentContext = previousContext; | ||
| const renderTarget = renderContext.renderTarget; |
Collaborator
Author
There was a problem hiding this comment.
The subsequent red code is moved into a new method _resolveRenderTarget().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
The WebGL backend of
WebGPURendereris currently unable to perform a manual clear with a multisampled render target.That happens because of a missing blit operation which does exist for the normal auto-clear. The code in
WebGLBackendis slightly refactored to ensurerenderer.clear()works as expected.The error itself can be reproduced with: https://jsfiddle.net/r15v3ebd/4/