TSL: Fix coordinate types for load() on 3D texture nodes
#31775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Contributor
Author
|
Mugen87
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the coordinate type for
load()on 3D texture nodes fromvec3toivec3.This also changes
TextureNodeso that it does not use a sampler whenhasSampler === falseandlevelNodeis set, because the level can be specified without a sampler (i.e.texture(node).level(0).load(uv)was previously forced to use a sampler but it shouldn't be necessary), but it does change its behavior.If agreed, we could give
generateTextureLoadhigher priority even when sampler-related options such asgradNodeandbiasNodeare set (i.e. move theif ( this.sampler === false )conditional to the beginning ofgenerateSnippet), becausesample()/load()can be considered actions and the others are options.