Examples: Clean up of FastHDR example #31829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The reversed rotation direction feels a bit uncommon. What do you mean with pano? The demo seems more like a normal viewer application to me. |
Collaborator
Author
|
I know it is subjective. I prefer to keep the same point under the pointer, and rotate in the same direction as the drag direction. As in these webgl examples: https://threejs.org/examples/?q=pano For some reason, this example seems to prefer that in my eyes... I'll restore the original rotation direction to prevent a blocking issue. |
Mugen87
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
White space clean up, mostly.
Since there was an animation loop present, I added damping.