SSGINode: Fix wrong bitfield typecast. #31873
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I checked out the new demo link and it seams that the "temporal filtering" toggle currently only turns off the temporal shift in noise pattern. Even with the option off I still see temporal "smearing" (very noticeable on the lightbulbs): 
(That smearing does not happen in any of the the AO, GI, Beauty passes) |
|
@hybridherbst Yes, the TAA is still in place even if the SSGI component does not use temporal offsets and directions to produce varying frame data. That has not changed with this PR. The demo setup is currently a bit easier if we don't have to switch between TAA and no TAA. So what you see is the ghosting from the TAA. |
|
Awesome! It looks so good now! You could tell I was really agonizing over the fact that the SSGI’s AO couldn’t “occlude” all the way to black in that other video 😅 I’m glad you found it!! I’ll make a new comparison soon! |
|
@Mugen87 thanks for clarifying! |
3 participants
Related issue: #31839
Description
The PR fixes a wrong bitfield typecast that was responsible for the wrong AO. With this fix, the
PI2fix from #31867 is not required anymore and the AO looks more correct now.This also fixes the deviations between the WebGPU and WebGL backend.
/ping @zalo
For comparison:
Dev: https://rawcdn.githack.com/mrdoob/three.js/bface43c1da1bb4c3f14b8353b8cee8a62cf8b1f/examples/webgpu_postprocessing_ssgi.html
PR: https://rawcdn.githack.com/mrdoob/three.js/98bad00d64693d7fef86523be915e2bd5096ec70/examples/webgpu_postprocessing_ssgi.html