EventDispatcher: Enhance iteration and add support for event listener objects #32720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to enhance
EventDispatcherby replacing the current array-based implementation with a map-based one. This removes the need for copying the listener array on eachdispatchEventcall since Map iteration supports adding and removing elements during iteration. See https://262.ecma-international.org/#sec-map.prototype.foreach for more details.In addition to listener functions, this PR also adds support for listener objects that implement a
handleEvent(event)method to be more in line with EventTarget.These changes are suggestions - the current implementation works just fine. I've tested webgl_shadowmap_performance which dispatches a lot of events and saw no obvious difference between the old and the new implementation in terms of performance and allocations.