BatchedMesh: Enable per-instance opacity #32725
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
Puppeteer doesn't like my screenshot - probably because of too many random values 🤔 I'll try changing the materials used in the demo back to |
gkjohnson
left a comment
gkjohnson
left a comment
There was a problem hiding this comment.
Just added some comments - at a high level I don't have an issue with the idea but I think there are some architectural complexities with vertex colors that make this more difficult.
Puppeteer doesn't like my screenshot - probably because of too many random values 🤔
It looks like the uploaded screenshot doesn't include any transparency. Here's the comparison downloaded from the CI artifacts:
| Commited | CI |
|---|---|
 |
 |
| @@ -1,5 +1,5 @@ | |||
| export default /* glsl */` | |||
| #if defined( USE_COLOR_ALPHA ) | |||
| #if defined( USE_COLOR_ALPHA ) || defined( USE_BATCHING_COLOR ) | |||
There was a problem hiding this comment.
It looks like we're still unnecessarily checking for "USE_BATCHING_COLOR" below
| #ifdef USE_COLOR | ||
| vColor *= color; |
There was a problem hiding this comment.
What happens when vertex colors without alpha are used with batching color, now? The attribute will be vec3 while vColor will be set to vec4 so I'd expect this to throw an error. And if we use vec4 for a 3-element attribute then I'd expect the alpha component to default to 0.
There was a problem hiding this comment.
Thanks for the review! I'll test this on Thursday.
2 participants
Description
Related: #28151
This PR adds support for per-instance opacity to
BatchedMesh. The current implementation ofBatchedMeshalready uses colors with 4 components and it supports sorting. The only thing missing is to use the alpha information in the shader.I've removed the
opacityoption from the example because it no longer made sense with per-instance transparency.This contribution is funded by Cozy Giant