GLTFLoader: Add getExtensionData helper. #32748
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
reviewed
Jan 14, 2026
|
|
||
| } | ||
|
|
||
| return { materialDef, extension: materialDef.extensions[ extensionName ] }; |
Collaborator
There was a problem hiding this comment.
It looks like this 'materialDef' property being returned is unused by the extension implementations, and could be removed. Possibly the helper function should be named getMaterialExtension or getMaterialExtensionData? Otherwise I do like the simplification!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduces code duplication in material extension classes by centralizing the extension check pattern into a single helper function.
(Made with Claude Opus 4.5)